Refactor Executor implementation into class #3301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacovCR
force-pushed
the
executor-as-class
branch
2 times, most recently
from
313e402 to
ab2c1f2
Compare
|
This diff is very large, mostly just whitespace changes from the class indentation. Not sure if you have a plugin or a way to browse around that. |
|
Silly me, GitHub reviews have an easy setting to toggle ignoring whitespace. Should be good to go. |
yaacovCR
force-pushed
the
executor-as-class
branch
2 times, most recently
from
58e3d24 to
462ada4
Compare
yaacovCR
force-pushed
the
move-execution-functions
branch
from
2325f66 to
0165c14
Compare
yaacovCR
force-pushed
the
executor-as-class
branch
from
462ada4 to
ff12454
Compare
yaacovCR
force-pushed
the
move-execution-functions
branch
from
0165c14 to
9354623
Compare
yaacovCR
force-pushed
the
executor-as-class
branch
from
ff12454 to
31bf31e
Compare
yaacovCR
force-pushed
the
move-execution-functions
branch
from
9354623 to
2ec2387
Compare
yaacovCR
force-pushed
the
executor-as-class
branch
from
31bf31e to
9b37080
Compare
yaacovCR
force-pushed
the
move-execution-functions
branch
from
2ec2387 to
4b0cfe3
Compare
yaacovCR
force-pushed
the
executor-as-class
branch
from
9b37080 to
d97dbfe
Compare
|
As per our offline discussion, I am forking the executor only and will be pushing forward asap with class based Executor over there, in order to jumpstart experimentation. Hopefully whatever works at graphql-executor can be integrated upstream as desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3300