Added specific eslint rules for typescript tests #2634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotansimha
changed the title
| '@typescript-eslint/no-throw-literal': off | ||
| '@typescript-eslint/require-await': off | ||
| '@typescript-eslint/await-thenable': off | ||
| 'prefer-promise-reject-errors': 0 |
There was a problem hiding this comment.
No all rules allow off as value, it gives an error. I think only TS rules allow off value.
| '@typescript-eslint/require-await': off | ||
| '@typescript-eslint/await-thenable': off | ||
| 'prefer-promise-reject-errors': 0 | ||
| 'no-new-wrappers': 0 |
There was a problem hiding this comment.
These are standard ESLint rules so they should work on both Flow and TS.
Can you please give an example of why you disabled them?
There was a problem hiding this comment.
Some of the tests are creating wrapped instances of primitives (for example - isCollection-test.js).
At the moment it has // eslint-disable-next-line no-new-wrappers set on those lines, but isn't it better to disable it on a global level? there are multiple places that does that.
|
@IvanGoncharov ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from: #2609
@IvanGoncharov