Add lighthouse to implementations #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
commented
Mar 21, 2023
spawnia
commented
Mar 21, 2023
enisdenjo
requested changes
Mar 21, 2023
enisdenjo
reviewed
Mar 21, 2023
|
This PR is good, but let me first take care of #60 (comment) because Lighthouse is compliant and it deserves to be in the compliant servers table. |
|
I have not had too much trouble with adding this implementation, but it might be valuable to have a guide for it. Would you welcome if I added one in a separate pull request? I would use |
Of course, more than welcome! Thank you in advance! |
spawnia
added a commit
to nuwave/lighthouse
that referenced
this pull request
Mar 21, 2023
|
Thanks @enisdenjo, I am happy to see that Lighthouse now passes the audit. |
enisdenjo
added a commit
that referenced
this pull request
Mar 31, 2023
Seems like when using `pull_request_target` trigger wont allow changes to the workflow file itself.
enisdenjo
approved these changes
Mar 31, 2023
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request adds https://lighthouse-php.com as an implementation.