Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: first pass at cypress e2e tests #985

Merged
merged 2 commits into from
Oct 23, 2019
Merged

chore: first pass at cypress e2e tests #985

merged 2 commits into from
Oct 23, 2019

Conversation

acao
Copy link
Member

@acao acao commented Oct 21, 2019

Some of these files were stubbed out by cypress, thinking of maybe adding some more tests as well, wanted to see how it runs in travis :D

@acao acao force-pushed the cypress branch 5 times, most recently from ca9518c to 8e84f39 Compare October 21, 2019 15:31
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope some of these comments are useful. Also your editor seems to not be linting/auto-fixing automatically?

packages/graphiql/cypress/integration/init.spec.js Outdated Show resolved Hide resolved
packages/graphiql/cypress/integration/init.spec.js Outdated Show resolved Hide resolved
@acao
Copy link
Member Author

acao commented Oct 23, 2019

@benjie it does not, but the pre-push hook took care of this. There are a bunch of linting/prettier fixes that need to be added in a seperate PR it looks like.

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #985 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #985   +/-   ##
=======================================
  Coverage   43.14%   43.14%           
=======================================
  Files          64       64           
  Lines        2934     2934           
  Branches      635      635           
=======================================
  Hits         1266     1266           
  Misses       1400     1400           
  Partials      268      268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09ce23...8a5684c. Read the comment docs.

@acao acao force-pushed the cypress branch 6 times, most recently from 5cb70f8 to c93e007 Compare October 23, 2019 13:52
@acao acao force-pushed the cypress branch 3 times, most recently from d9cdf8f to 88b6e40 Compare October 23, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants