-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(subscriptions): added graphql-subscriptions support #340
Conversation
Hi @Urigo - I'm not sure if |
I agree with @asiandrummer - If I'd prefer that we don't introduce volatility into GraphiQL's test harness until subscriptions are supported in a more first-class way, and that when we do so we don't upset the existing test coverage. |
@asiandrummer @leebyron sorry got the late response. Maybe we could leave this PR open as kind of RFC like thing for GraphiQL and subscriptions? Anyway for people who want to use GraphiQL with subscriptions today, I wrote a blog post about it - https://dev-blog.apollodata.com/how-to-use-subscriptions-in-graphiql-1d6ab8dbd74b |
cc @robzhu for context |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Hey @Urigo, this seems to have been sitting here for a while and since we haven't really been able to come to a consensus on this, and I'm not sure what direction we're taking with this, I'm going to close this for now. Thanks for the contribution. |
Adding subscriptions support with the subscriptions-transport-ws library.
Replaced dummy subscription with timeSubscription and publish it every second.