Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: fix query argument missing from onEditQuery call" #1442

Closed
wants to merge 1 commit into from

Conversation

acao
Copy link
Member

@acao acao commented Mar 27, 2020

Reverts #1440 because coverage ratio was too low. Needs a test first.

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #1442 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1442   +/-   ##
=======================================
  Coverage   58.98%   58.98%           
=======================================
  Files          60       60           
  Lines        3023     3023           
  Branches      796      796           
=======================================
  Hits         1783     1783           
  Misses       1194     1194           
  Partials       46       46
Impacted Files Coverage Δ
packages/graphiql/src/components/GraphiQL.tsx 58.89% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c335a8...2e6c879. Read the comment docs.

@acao acao closed this Mar 27, 2020
@acao acao deleted the revert-1440-crit--fix-oneditquery branch May 13, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant