Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-ui] Panels & themes #1157

Merged
merged 21 commits into from
Dec 27, 2019
Merged

[new-ui] Panels & themes #1157

merged 21 commits into from
Dec 27, 2019

Conversation

walaura
Copy link
Contributor

@walaura walaura commented Dec 23, 2019

Thinking out loud and writing docs about how to do themability here, comments welcome!

I also added new components for flex layouts (super exciting) and pink titles (actually exciting)

And made it so storybook automatically generates jest snaps, this seems pretty sensible because they are basically the same thing.

@walaura walaura changed the title Panels & themes [new-ui] Panels & themes Dec 23, 2019
@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #1157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1157   +/-   ##
=======================================
  Coverage   48.68%   48.68%           
=======================================
  Files          64       64           
  Lines        3003     3003           
  Branches      650      650           
=======================================
  Hits         1462     1462           
  Misses       1306     1306           
  Partials      235      235

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de73d6c...9b754a5. Read the comment docs.

babel.config.js Outdated Show resolved Hide resolved
@acao
Copy link
Member

acao commented Dec 23, 2019

@walaura thanks a bunch, this is looking so splendid! giving me all kinds of ideas for the frontbackend side of things, seeing things come to fruition on this side

@walaura
Copy link
Contributor Author

walaura commented Dec 23, 2019

yas!!! so excited to hear

);
};

Layout.propTypes = LAYOUT_PROP_TYPES;
Copy link
Member

@acao acao Dec 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes perfect sense for now, but as you may know we are converting to typescript within a month ish by very popular demand. once we get some architectural changes implemented

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg honestly can't wait!! i feel a bit like freefalling in here not having typechecking. Can I use TS on this part already?

@acao
Copy link
Member

acao commented Dec 27, 2019

looks good to merge! whatchu think @walaura

@acao acao merged commit 30a9094 into graphql:master Dec 27, 2019
@acao acao added this to the GraphiQL-1.0.0-beta milestone Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants