Change body type of juniper-hyper functions from Body to String
#1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKalbertodt
force-pushed
the
improve-hyper-body-type
branch
from
2175920 to
bf0242c
Compare
All responses were created from strings anyway (via `Body::from`), but `String` implements the `Body` trait directly. With this change, it is easy to inspect the response body, which is not true for `Body`. Fixes graphql-rust#1096
LukasKalbertodt
force-pushed
the
improve-hyper-body-type
branch
from
bf0242c to
49f5a6f
Compare
|
The single CI failure is not caused by the changes and needs to be restarted. |
tyranron
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All responses were created from strings anyway (via
Body::from), butStringimplements theBodytrait directly. With this change, it is easy to inspect the response body, which is not true forBody.Fixes #1096