Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pedantic Clippy fixes #512

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

pedantic Clippy fixes #512

wants to merge 24 commits into from

Conversation

danieleades
Copy link
Contributor

No description provided.

@danieleades danieleades marked this pull request as ready for review January 31, 2025 09:53
@danieleades
Copy link
Contributor Author

note that these changes bump the MSRV (which may not be desirable)!

@tomhoule
Copy link
Member

Thanks for doing this. Let's bump the MSRV and release this once 0.15.0 is out. I expect 0.16.0 to have a bunch of breaking changes.

daniel.eades and others added 24 commits February 7, 2025 14:25
use inline format args (clippy::uninlined_format_args)
73ea25a
use 'Self' keyword (clippy::use_self)
3738ec9
use semicolon if nothing returned (clippy::semicolon_if_nothing_retur…
22e74ec 
…ned)
remove explicit 'iter' loops (clippy::explicit_iter_loop)
0363779
avoid cloning when you can copy (clippy::cloned_instead_of_copied)
c8cd180
remove unnecessary semicolons (clippy::unnecessary_semicolons)
4c28f68
nest or patterns (clippy::unnested_or_patterns)
e89ea51
use 'if let' rather than single match 'else' block (clippy::single_ma…
1b008bf 
…tch_else)
collapse some 'if else' blocks
e2cb44d
remove needless raw string hashes (clippy::needless_raw_string_hashes)
df3d21c
remove wildcard imports (clippy::wildcard_imports)
b609d7d
bump MSRV
59b7ffc
flip unnecessary booleans (clippy::if_not_else)
35f5699
remove redundant 'else' block (clippy::redundant_else)
171e859
use 'assert' macro (clippy::manual_assert)
9dd61dd
explicitly match unit values (clippy::ignored_unit_patterns)
87db1ea
@danieleades
remove some redundant closures (clippy::redundant_closure)
aacca46
@danieleades
remove use of 'lazy_static' (clippy::non_std_lazy_statics)
10a76b6
@danieleades
bump msrv
882b5d6
@danieleades
remove some needlessly mutable references (clippy::needless_pass_by_r…
b3fd448 
…ef_mut)
@danieleades
general refactoring
9d0d2b7
@danieleades
deglob another import
7de6d9a
@danieleades
remove unnecessary wraps (clippy::unnecessary_wraps)
1380bf7
minor refactoring
236ff5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieleades @tomhoule