Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert E2Es to examples #379

Merged
merged 123 commits into from
Dec 31, 2024
Merged

Convert E2Es to examples #379

merged 123 commits into from
Dec 31, 2024

Conversation

enisdenjo
Copy link
Member

@enisdenjo enisdenjo commented Dec 25, 2024

  • Transforms an E2E test to a runnable example
    • Never worry about writing examples, write E2Es and let the @internal/examples converter do the rest
  • The converter makes sure examples work by running them and checking whether gateway is healthy
  • Runs in CI
    • Examples are always be up-to-date with the latest versions
    • Examples are continuously tested through E2Es and by the converter itself which makes sure the gateway is healthy after running
    • As we cut new versions, examples will update too
  • Plug-n-Play for Codesandbox Devboxes

TODO

  • Warn that examples are auto-generated and not to be modified directly
  • Container Sandboxes are deprecated, use Codesandbox Devboxes instead
  • Support createExampleSetup
  • Convert rest of relevant E2Es
  • Run containers used for E2Es (do Codesandbox Deboxes even support it?)

@enisdenjo enisdenjo marked this pull request as ready for review December 28, 2024 23:57
strategy:
matrix:
e2e:
- extra-fields
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will create workflows for each example which might cause a bigger queue. But instead maybe we can run this once and configure converted e2es in a file, no?

@ardatan ardatan merged commit 1fbdf70 into main Dec 31, 2024
54 checks passed
@ardatan ardatan deleted the e2e2example branch December 31, 2024 11:29
@Urigo
Copy link

Urigo commented Dec 31, 2024

very cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants