Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: thunks return signature improvement #393

Merged
merged 2 commits into from
Sep 11, 2018

Conversation

chris-ramon
Copy link
Member

@chris-ramon chris-ramon commented Sep 10, 2018

Overview

Test plan

  • Unit tests

@chris-ramon chris-ramon force-pushed the 367-with-bfs-thunk-return-signature branch from a6c7dac to 5cac42b Compare September 10, 2018 15:47
@coveralls
Copy link

coveralls commented Sep 10, 2018

Coverage Status

Coverage increased (+0.006%) to 91.629% when pulling fc3fae5 on 367-with-bfs-thunk-return-signature into b3d68b1 on master.

Now thunks matches the return `Resolve(...) (interface{}, error)` signature
for consistency.
@chris-ramon chris-ramon merged commit cd6ef8d into master Sep 11, 2018
@chris-ramon chris-ramon deleted the 367-with-bfs-thunk-return-signature branch September 11, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants