Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tapSubgraph to be an optional value #904

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

carlosvdr
Copy link
Contributor

Ford found out tapsubgraph is not an optional value so changed a few things to make it work

@carlosvdr carlosvdr self-assigned this Jun 6, 2024
@carlosvdr carlosvdr requested a review from aasseman June 7, 2024 16:34
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a quick solution, LGTM.

Longer term it'd be nice to have a cleaner solution. In particular it'd be nice to warn the indexer if we see RAVs in the DB but we don't have the right settings to act on them.

@aasseman aasseman requested a review from fordN June 7, 2024 17:19
@fordN
Copy link
Contributor

fordN commented Jun 11, 2024

Nice, thanks for the quick fix! 🙏

There is still another backwards compatibility issue with the TAP integration though. If the indexer-agent is connected to a network without TAP contracts deployed it fails to startup: runs into an unhandled promise rejection. I'll create an issue to track and we can resolve in a subsequent PR.

Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once it's confirmed working for an indexer without tapSubgraph configured let's get merged in.

Copy link

gitguardian bot commented Jun 27, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12241928 Triggered Generic High Entropy Secret e78f269 network-configs/config.yaml View secret
12251296 Triggered Generic High Entropy Secret e78f269 network-configs/config.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

carlosvdr and others added 2 commits June 27, 2024 14:56
Signed-off-by: Carlos V <carlos.vdr@semiotic.ai>
Signed-off-by: Carlos V <carlos.vdr@semiotic.ai>
@dwerner dwerner merged commit bda5d93 into main Jun 27, 2024
9 of 10 checks passed
@dwerner dwerner deleted the optional-tap-subgraph branch June 27, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🚗 Merged
4 participants