agent,common: Migrate subgraph deployment assignments to use explicit 'paused' mechanism #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fordN
force-pushed
the
ford/deployments-use-pause-mechanism
branch
2 times, most recently
from
db0c741
to
e631b87
Compare
fordN
force-pushed
the
ford/deployments-use-pause-mechanism
branch
from
e631b87
to
9ded337
Compare
- Use subgraph_pause JSON-RPC method instead of subgraph_reassign, which explicitly pauses subgraph instead of virtually pausing it by moving it to a non-existent index node
- Leave subgraph deployment assignment decisions to the graph-node, configurable in the graph-node.toml config file
- Ahead of executing a batch, ensure all deployments to be allocated to are ensured - Check status of subgraph deployment assignments: if already syncing then no-op, if paused then resume, if doesn't exist then create and deploy
- When confirming an unallocate action has succeeded, upsert an indexing rule for that deployment with decisionBasis=Never.
fordN
force-pushed
the
ford/deployments-use-pause-mechanism
branch
from
915de90
to
d453475
Compare
fordN
commented
Jul 11, 2024
|
@dwerner I added a few more commits here. I think it's worth reviewing again, thanks! |
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graph-node recently added support for explicit pausing of subgraph deployments (in the past they were paused virtually by assigning the deployment to a nonexistent node).
This PR adds a migration that interacts with the Graph Node indexingStatuses query and JSON-RPC server to update all virtually paused deployments (node = 'removed') to use the new explicit pausing mechanism. It also updates the process of deploying subgraphs, the indexer-agent will no longer specify the index node to which the deployment is assigned; instead the graph-node makes the assignment decisions.
Changes