agent,common: Improve control of subgraph deployment health safety check #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fordN
force-pushed
the
ford/improve-control-of-subgraph-health-safety
branch
2 times, most recently
from
ee0eb0e
to
b5cc50e
Compare
- Previously the safety check occurred later in the process. We should identify early that a subgraph is failed and safety = true to not add the action to the queue in the first place. The other benefit of moving this check is so it has access to the corresponding rule so the safety property can be used here for control.
fordN
force-pushed
the
ford/improve-control-of-subgraph-health-safety
branch
from
b5cc50e
to
07ad76b
Compare
saihaj
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effect
indexingRule.safety = trueto turn on the deployment health check. The agent will not allocate to the deployment if it hashealth = failed.indexingRule.safety = false or nullto turn off the deployment health check. The agent will still allocate to subgraph deployments withhealth = failed.Changes
reconcileDeploymentAllocationAction(). This gives the check access to the indexingRule so it can use thesafetyproperty, it also is useful to prevent action from being added to the queue in the first place. In the previous/current setup the action does not included in a transaction but it will remain in the queue and continue to be retried.