indexer-common: Implement stake feasibility check #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since accessing GRT values for unallocation is expensive, this commit introduces the ResolvedAction wrapper interface, which aims to cache GRT values of Unnalocate Actions as well storing its GRT balance during the validation process.
fordN
reviewed
Jan 26, 2023
Encapsulates all allocation fetching inside AllocationManager into a dedicated function.
We decided to stick with error code IE013 for signaling batch stake insufficiency. Also, we will tackle gasLimits on a new PR.
fordN
reviewed
Jan 27, 2023
fordN
reviewed
Jan 30, 2023
packages/indexer-common/src/indexer-management/__tests__/resolvers/actions.ts
Outdated
Show resolved
Hide resolved
packages/indexer-common/src/indexer-management/__tests__/resolvers/actions.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces stake feasibility check for Action batches.
Before this, batches would be rejected even if their gross value fits in the free stake final balance.
Tasks: