Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indexer-cli, -common: allow status latestBlock to be nullable #453

Merged
merged 1 commit into from
Aug 4, 2022
Merged

indexer-cli, -common: allow status latestBlock to be nullable #453

merged 1 commit into from
Aug 4, 2022

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Aug 3, 2022

for #443
A few months ago we made earliestBlock nullable which is a common occurrence for subgraph deployments. For unlikely edge cases we allow latestBlock and chainHeadBlock to be null as well.

@hopeyen hopeyen added the bug Something isn't working label Aug 3, 2022
@hopeyen hopeyen requested a review from fordN August 4, 2022 19:20
fordN
fordN approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved to merge after you rebase on main and use the testnet network subgraph hosted-service endpoint in the tests.

packages/indexer-common/src/indexer-management/__tests__/actions.ts Outdated Show resolved Hide resolved
@fordN
Copy link
Contributor

fordN commented Aug 4, 2022

Resolves #443

@hopeyen hopeyen force-pushed the hope/nullable-latestBlock branch from d579000 to 27f3ce8 Compare August 4, 2022 20:39
@hopeyen hopeyen force-pushed the hope/nullable-latestBlock branch from 27f3ce8 to fa5d1b6 Compare August 4, 2022 20:57
@hopeyen hopeyen merged commit 1da01fc into main Aug 4, 2022
@hopeyen hopeyen deleted the hope/nullable-latestBlock branch August 4, 2022 21:24
@fordN fordN linked an issue Aug 17, 2022 that may be closed by this pull request
Bug: indexer status fails if a chain indexing status is missing latestBlock value #443
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fordN fordN fordN approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: indexer status fails if a chain indexing status is missing latestBlock value
2 participants
@hopeyen @fordN