indexer-cli: indexing rule parser error catch #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Can we also output the help text after the message so the user can see what the supported parameters are? |
hopeyen
force-pushed
the
hope/cli-rules-parser-errors
branch
from
a3643c9 to
f16feaa
Compare
I ended up making a simple dumb suggestion function: if there's valid commands that shares 80% of the inputted letters, print those, otherwise print all available commands. Let me know if you think the help text would be better? |
hopeyen
force-pushed
the
hope/cli-rules-parser-errors
branch
from
f16feaa to
cde4fd4
Compare
fordN
reviewed
May 18, 2022
packages/indexer-common/src/indexer-management/models/indexing-rule.ts
Outdated
Show resolved
Hide resolved
hopeyen
force-pushed
the
hope/cli-rules-parser-errors
branch
4 times, most recently
from
d48a094 to
6240193
Compare
|
@hopeyen what's the status on this PR? Ready for another review? |
|
yep this one is ready for another review! thanks in advance |
fordN
reviewed
Jul 29, 2022
hopeyen
force-pushed
the
hope/cli-rules-parser-errors
branch
3 times, most recently
from
a82cd26 to
cb16912
Compare
hopeyen
commented
Jul 29, 2022
hopeyen
force-pushed
the
hope/cli-rules-parser-errors
branch
from
cb16912 to
7104b65
Compare
hopeyen
force-pushed
the
hope/cli-rules-parser-errors
branch
from
7104b65 to
d04b116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using wrong arguments for
indexer rules set, the error messageTypeError: INDEXING_RULE_PARSERS[key] is not a functionis not very clear.
Improve the error message to specify the invalid key: when provided a non-existing attribute, return messages like
Indexing rule attribute 'allocatoinAmount' doesn't exist, please check spellingfor next step: can make suggestions using modules like
spellchecker-cli