-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indexer Agent Configuration by File #396
Conversation
Hey @fordN , @chriswessels , and @hopeyen , I've merged in changes from Also, the format check for |
Could you try removing |
What do you think about submitting a similar PR for the indexer-service @kaiwetlesen? |
Can you clean up your commit history here so there is an easily followable path? There should only be one commit for this big of a change and no merge commits. |
@kaiwetlesen this is still showing 14 commits and includes merge commits. Please rebase on main and squash your commits to a single commit, it's only a 15 line change... |
7b38747
to
b334fe6
Compare
@fordN done. Misunderstood what you'd asked for before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
** RECREATING THIS PR** from PR #395 as the CI pipeline didn't like building off of a fork.
This pull requests implements file-based configuration for the indexer agent such that the configuration file supplements base defaults for a cluster. The idea here is that default values for mainnet, rinkeby, etc can be supplied as code in the repository, with more important parameters being injected via environment variables and CLI flags.
The order of precedence is as follows:
F.eks. running indexer-agent with a configuration file containing ethereum: https://ethereum-node-0:8545 and setting INDEXER_AGENT_ETHEREUM to https://ethereum.hosted.service/accountid/, the effective setting would be https://ethereum.hosted.service/accountid/.