Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer-agent: Support deployment id rules using either id format #361

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Jan 31, 2022

Support both formats of subgraph deployment id: bytes32 or base58.

@fordN fordN force-pushed the ford/handle-both-deployment-id-formats branch from 73d0f79 to d2df029 Compare January 31, 2022 22:44
- Deployment id formats supported: bytes32 or base58.
- Include unit tests for convertSubgraphBasedRulesToDeploymentBased().
@fordN fordN force-pushed the ford/handle-both-deployment-id-formats branch from d2df029 to 6cf72b3 Compare January 31, 2022 22:54
Copy link
Contributor

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🥇

@fordN fordN merged commit 88c0709 into main Feb 1, 2022
@fordN fordN deleted the ford/handle-both-deployment-id-formats branch February 1, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants