Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer-cli,indexer-common: Setup CLI test harness, create initial test suites #358

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Jan 27, 2022

Updates

Indexer-common

  • createIndexerManagementServer() now returns the server instance, so it can be properly shutdown after each test.

Indexer-cli

  • Add test harness for integration testing CLI commands.
  • Include a few initial test suites covering:
    • general indexer-cli setup and help commands,
    • indexer rules commands.

@fordN fordN requested a review from hopeyen January 27, 2022 19:04
@fordN fordN force-pushed the ford/cli-tests branch 5 times, most recently from 42ecb2d to e0638fd Compare January 27, 2022 21:09
Copy link
Contributor

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fordN fordN force-pushed the ford/cli-tests branch 7 times, most recently from 03e4c66 to d3f4974 Compare January 28, 2022 18:06
- Initial tests added:
  - Test suite for general indexer cli setup commands
  - Test suite for indexer rules commands
- Update createIndexerManagementServer() to return the server instance,
so it can be properly shutdown after each test.
- Update workflow CI to use postgres and graph-node container services
for tests.
- Turning off the indexer-service tests in CI for now until I've
added a graph-node container service to the CI test infra.
@fordN fordN merged commit 5a784d8 into main Jan 28, 2022
@fordN fordN deleted the ford/cli-tests branch January 28, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants