Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #338

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Upgrade dependencies #338

merged 3 commits into from
Jan 6, 2022

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Dec 21, 2021

  • Upgrade dependencies to latest.
  • Code changes required for the Ethers, Graphql, graphql-tools, and Sequelize upgrades.
  • Remove unused and unmaintained (no commits since July) Connext vector dependencies.
  • Improve test configurations.
  • Fix tests.

@fordN fordN force-pushed the ford/upgrade-dependency-packages branch from e66af04 to 6ef1773 Compare December 22, 2021 21:20
@fordN fordN force-pushed the ford/upgrade-dependency-packages branch 2 times, most recently from d497506 to cead997 Compare December 22, 2021 22:04
Copy link
Contributor

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ford, happy holidays :) No urgency here if you see it during time-off

I ran into some installation issues as follows with M1 machine and node@15.14.0

  • Encountered dependency conflict with npmcli/fs. Due to earlier troubleshooting which established that graph-node in M1 requires node@15. Thus, updated node to 16 which is the latest stable.

  • Next encountered no file found for neon in cost-modules. The only place I found related to neon is Cargo.toml in indexer-native. Tried to install neon separately in both node15 and node16, but still encounter the following error

error: failed to run custom build command for `neon-sys v0.5.3`

Caused by:
  process didn't exit successfully: `/Users/hopeyen/projects/indexer/node_modules/@graphprotocol/cost-model/native/target/debug/build/neon-sys-a77da049a02359d0/build-script-build` (exit status: 1)
  --- stdout
  Skipping node-gyp installation as part of npm install.
  cargo:node_arch=arm
  TARGET = Some("aarch64-apple-darwin")
  HOST = Some("aarch64-apple-darwin")
  AR_aarch64-apple-darwin = None
  AR_aarch64_apple_darwin = None
  HOST_AR = None
  AR = None
  running: "ar" "cq" "/Users/hopeyen/projects/indexer/node_modules/@graphprotocol/cost-model/native/target/debug/build/neon-sys-4e57d06d32ad90f7/out/libneon.a" "/Users/hopeyen/projects/indexer/node_modules/@graphprotocol/cost-model/native/target/debug/build/neon-sys-4e57d06d32ad90f7/out/native/build/Debug/obj.target/neon/src/neon.o"
  cargo:warning=ar: /Users/hopeyen/projects/indexer/node_modules/@graphprotocol/cost-model/native/target/debug/build/neon-sys-4e57d06d32ad90f7/out/native/build/Debug/obj.target/neon/src/neon.o: No such file or directory
  exit status: 1

  --- stderr

  error occurred: Command "ar" "cq" "/Users/hopeyen/projects/indexer/node_modules/@graphprotocol/cost-model/native/target/debug/build/neon-sys-4e57d06d32ad90f7/out/libneon.a" "/Users/hopeyen/projects/indexer/node_modules/@graphprotocol/cost-model/native/target/debug/build/neon-sys-4e57d06d32ad90f7/out/native/build/Debug/obj.target/neon/src/neon.o" with args "ar" did not execute successfully (status code exit status: 1).

warning: build failed, waiting for other jobs to finish...
error: build failed
neon ERR! cargo build failed

Error: cargo build failed
    at Target.<anonymous> (/Users/hopeyen/projects/indexer/node_modules/@graphprotocol/cost-model/node_modules/neon-cli/lib/target.js:98:27)

@fordN
Copy link
Contributor Author

fordN commented Jan 5, 2022

@hopeyen thanks for testing and reviewing! As you noticed, there are some known issues building @graphprotocol/cost-model on node versions > 14 that need to be addressed.

@fordN fordN force-pushed the ford/upgrade-dependency-packages branch 2 times, most recently from 0a773db to c436e87 Compare January 6, 2022 20:45
@fordN fordN force-pushed the ford/upgrade-dependency-packages branch from c436e87 to f528692 Compare January 6, 2022 20:49
@fordN fordN force-pushed the ford/upgrade-dependency-packages branch from f528692 to 6946eff Compare January 6, 2022 20:57
@fordN fordN merged commit f57fefd into main Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants