Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace dips route with grpc server #529

Merged
merged 1 commit into from
Jan 2, 2025
Merged

refactor: replace dips route with grpc server #529

merged 1 commit into from
Jan 2, 2025

Conversation

mangas
Copy link
Collaborator

@mangas mangas commented Dec 3, 2024

No description provided.

@mangas mangas force-pushed the dips-grpc branch 11 times, most recently from 922923c to 7bf470f Compare December 3, 2024 23:01
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12583173868

Details

  • 103 of 603 (17.08%) changed or added relevant lines in 6 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-3.2%) to 77.456%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/dips/src/store.rs 8 13 61.54%
crates/dips/src/lib.rs 83 101 82.18%
crates/service/src/service.rs 0 36 0.0%
crates/dips/src/server.rs 0 43 0.0%
crates/dips/src/proto/graphprotocol.indexer.dips.rs 0 398 0.0%
Files with Coverage Reduction New Missed Lines %
crates/tap-agent/src/agent/sender_allocation.rs 3 88.33%
crates/tap-agent/src/agent/sender_account.rs 9 82.99%
Totals Coverage Status
Change from base Build 12547934611: -3.2%
Covered Lines: 6789
Relevant Lines: 8765
💛 - Coveralls

@mangas mangas marked this pull request as ready for review December 3, 2024 23:17
@mangas mangas requested review from gusinacio and LNSD December 3, 2024 23:17
@mangas mangas force-pushed the dips-grpc branch 9 times, most recently from f7bae2c to 69cedf3 Compare December 9, 2024 18:04
@mangas mangas requested a review from carlosvdr December 10, 2024 15:23
@mangas mangas enabled auto-merge (squash) December 11, 2024 10:19
gusinacio
gusinacio previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it won't affect current system. LGTM

@gusinacio gusinacio changed the title dips grpc refactor: replace dips route with grpc server Dec 16, 2024
@mangas mangas requested a review from gusinacio January 2, 2025 13:59
@mangas mangas merged commit 1263fb7 into main Jan 2, 2025
10 checks passed
@mangas mangas deleted the dips-grpc branch January 2, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

@LNSD LNSD Awaiting requested review from LNSD

@carlosvdr carlosvdr Awaiting requested review from carlosvdr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mangas @gusinacio