Allow (autogenerated) Int8 id values
#5029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutter
force-pushed
the
lutter/int8
branch
6 times, most recently
from
fd56c20 to
b410030
Compare
leoyvens
requested changes
Nov 30, 2023
| @@ -624,6 +624,7 @@ fn id_type_as_scalar( | |||
| }?; | |||
| let scalar_type = id_type.map(|id_type| match id_type { | |||
| IdType::String | IdType::Bytes => ScalarType::new(String::from("String")), | |||
| IdType::Int8 => ScalarType::new(String::from("Int")), | |||
There was a problem hiding this comment.
Shouldn't this be "Int8"?
There was a problem hiding this comment.
Nice catch, and a fun way to spend a few hours why this works with Int but not with Int8 - the upshot is that Int8 gets treated as a string internally in too many places, and queries just blow up in that case. Addressing that is a little scary and I've opened the separate PR #5034 to do that.
For this PR, I just left a big comment why it's Int and not Int8 for now.
leoyvens
approved these changes
Dec 1, 2023
dotansimha
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it is possible to use
Int8as the type of an entity'sid. In addition, whenstore.setis called with the id argument set to"auto", an id is auto-generated (see the comment onIdType::generate_idfor details)Auto-generation is also possible if the type of
idisBytesFor now, this is really only useful for immutable entities as it's not possible to find out what the id was set to from the mappings; we should address that in a future PR.
Fixes #5018