-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add substreams block ingestor #4839
Conversation
mangas
commented
Aug 29, 2023
- Substreams ingestor not currently allowed for supported chains
- Chains using substreams protocol can only have substreams endpoints
- Add substream-head-tracker to the project
- Embed substreams-head-tracker in substreams block ingestor
- Substreams ingestor not currently allowed for supported chains - Chains using substreams protocol can only have substreams endpoints - Add substream-head-tracker to the project - Embed substreams-head-tracker in substreams block ingestor
@@ -0,0 +1,4 @@ | |||
[toolchain] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we have a way to use the top-level one directly. Only thing I'm wondering is the wasm32-unknown-unknown
target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I have the necessary context to thoroughly review this, so it's great to have other eyes on this. This is pretty in line with what I would expect though, LGTM.
latest_cursor = self.process_blocks(latest_cursor, stream).await; | ||
|
||
// If we reach this point, we must wait a bit before retrying | ||
backoff.sleep_async().await; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like backoff
is never reset, which is not ideal. Maybe should reset if cursor changes.