-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete 'shallow' fh eth blks on rpc+ingestor start #4790
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
864b3e6
delete 'shallow' fh eth blks on rpc+ingestor start
sduchesneau a952853
cleanup shallowblocks only within reorg threshold, remove nulldata in…
sduchesneau e6a80bd
also remove cursor on non-firehose ethereum chains
sduchesneau 3302d5b
delete_shallowblocks: check for overflow, use double reorg_threshold …
sduchesneau 5e85dc4
add comment with github pr link regarding cleanup_shallow_blocks
sduchesneau 3cfca28
Only remove shallow blocks if cursor was removed
sduchesneau 170105c
minor style improvements
sduchesneau 630fca4
more minor style refinement in block_store
sduchesneau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
17 changes: 0 additions & 17 deletions
17
store/postgres/migrations/2023-06-22_050000_index_ethereum_nulldata/down.sql
This file was deleted.
Oops, something went wrong.
26 changes: 0 additions & 26 deletions
26
store/postgres/migrations/2023-06-22_050000_index_ethereum_nulldata/up.sql
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -456,9 +456,15 @@ impl BlockStore { | |
continue; | ||
}; | ||
} | ||
match store.chain_head_block(&&store.chain).unwrap_or(None) { | ||
Some(head) => { | ||
let lower_bound = head - ENV_VARS.reorg_threshold; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Check for overflow. Also I'd give some slack here so we don't have to worry about off by one, race conditions or whatever, maybe use |
||
|
||
info!(&self.logger, "Cleaning shallow blocks on non-firehose chain"; "network" => &store.chain); | ||
store.cleanup_shallow_blocks()? | ||
info!(&self.logger, "Cleaning shallow blocks on non-firehose chain"; "network" => &store.chain, "lower_bound" => lower_bound); | ||
store.cleanup_shallow_blocks(lower_bound)? | ||
} | ||
None => {} | ||
} | ||
} | ||
Ok(()) | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
if let Some(head) = store.chain_head_block(&&store.chain)?