graph: fix backoff overflow #4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutter
requested changes
Mar 6, 2023
| @@ -33,7 +33,7 @@ impl ExponentialBackoff { | |||
| } | |||
|
|
|||
| pub fn delay(&self) -> Duration { | |||
| let mut delay = self.base.saturating_mul(1 << self.attempt); | |||
| let mut delay = self.base.saturating_mul(1u32 << self.attempt.min(31)); | |||
There was a problem hiding this comment.
I think it would be better to make sure that next_attempt never increments self.attempt to more than 31. We can also do the min here in addition, but I think we should also clamp self.attempt to 31 explicitly
There was a problem hiding this comment.
Thought it would be better to let it increment to have a sense how many total attempts there were, i.e. for logging.
lutter
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with
backoffleft shift overflow #4420Also adds tests for that struct.