Remove unused deps from graph-server-metrics

graph/src/components/server/mod.rs

@@ -6,6 +6,3 @@ pub mod subscription;
 
 /// Component for the index node server.
 pub mod index_node;
-
-/// Components for the Prometheus metrics server.
-pub mod metrics;

graph/src/lib.rs

@@ -115,7 +115,6 @@ pub mod prelude {
         PrometheusError, Registry,
     };
     pub use crate::components::server::index_node::IndexNodeServer;
-    pub use crate::components::server::metrics::MetricsServer;
     pub use crate::components::server::query::GraphQLServer;
     pub use crate::components::server::subscription::SubscriptionServer;
     pub use crate::components::store::{

node/src/main.rs

@@ -568,12 +568,12 @@ async fn main() {
                 .compat(),
         );
 
-        graph::spawn(
+        graph::spawn(async move {
             metrics_server
                 .serve(metrics_port)
+                .await
                 .expect("Failed to start metrics server")
-                .compat(),
-        );
+        });
     };
 
     graph::spawn(launch_services(logger.clone(), env_vars.cheap_clone()));

server/metrics/Cargo.toml

@@ -5,7 +5,4 @@ edition.workspace = true
 
 [dependencies]
 graph = { path = "../../graph" }
-http = "0.2"
 hyper = { version = "0.14", features = ["server"] }
-lazy_static = "1.2.0"
-serde = "1.0"

server/metrics/src/lib.rs

@@ -2,13 +2,13 @@ use std::net::{Ipv4Addr, SocketAddrV4};
 use std::sync::Arc;
 
 use anyhow::Error;
-use graph::prometheus::{Encoder, Registry, TextEncoder};
 use hyper::header::{ACCESS_CONTROL_ALLOW_ORIGIN, CONTENT_TYPE};
 use hyper::service::{make_service_fn, service_fn};
 use hyper::{Body, Response, Server};
 use thiserror::Error;
 
-use graph::prelude::{MetricsServer as MetricsServerTrait, *};
+use graph::prelude::*;
+use graph::prometheus::{Encoder, Registry, TextEncoder};
 
 /// Errors that may occur when starting the server.
 #[derive(Debug, Error)]
@@ -30,15 +30,12 @@ impl PrometheusMetricsServer {
             registry,
         }
     }
-}
-
-impl MetricsServerTrait for PrometheusMetricsServer {
-    type ServeError = PrometheusMetricsServeError;
 
-    fn serve(
+    /// Creates a new Tokio task that, when spawned, brings up the index node server.
+    pub async fn serve(
         &mut self,
         port: u16,
-    ) -> Result<Box<dyn Future<Item = (), Error = ()> + Send>, Self::ServeError> {
+    ) -> Result<Result<(), ()>, PrometheusMetricsServeError> {
         let logger = self.logger.clone();
 
         info!(
@@ -73,6 +70,6 @@ impl MetricsServerTrait for PrometheusMetricsServer {
             .serve(new_service)
             .map_err(move |e| error!(logger, "Metrics server error"; "error" => format!("{}", e)));
 
-        Ok(Box::new(task.compat()))
+        Ok(task.await)
     }
 }