add partial account filters for near #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
force-pushed
the
near-partial-account-filters
branch
from
ae831df to
701370d
Compare
mangas
force-pushed
the
near-partial-account-filters
branch
from
701370d to
dce8459
Compare
evaporei
approved these changes
Jun 20, 2022
chain/near/src/adapter.rs
Outdated
Comment on lines
145
to
146
| // prefix [] and suffiex [c, d] would produce [None, c], [None, d] | ||
| // prefix [a,b] and suffiex [] would produce [a, None], [b, None] |
Comment on lines
+11
to
+15
| // PrefixSuffixPair applies a logical AND to prefix and suffix when both fields are non-empty. | ||
| // * {prefix="hello",suffix="world"} will match "hello.world" but not "hello.friend" | ||
| // * {prefix="hello",suffix=""} will match both "hello.world" and "hello.friend" | ||
| // * {prefix="",suffix="world"} will match both "hello.world" and "good.day.world" | ||
| // * {prefix="",suffix=""} is invalid |
There was a problem hiding this comment.
It's nice to have docs here, thanks 👍
Comment on lines
465
to
+468
| pub(crate) account: Option<String>, | ||
| #[serde(rename = "startBlock", default)] | ||
| pub(crate) start_block: BlockNumber, | ||
| pub(crate) accounts: Option<PartialAccounts>, |
There was a problem hiding this comment.
I see that account and accounts are optional. What happens if one tries to deploy a NEAR subgraph that has both values as None? Do you know if we have validation for this or if is it valid?
| if no_source_address && has_receipt_handlers { | ||
|
|
||
| // Validate not both address and partial addresses are empty. | ||
| if (no_source_address && no_partial_addresses) && has_receipt_handlers { | ||
| errors.push(SubgraphManifestValidationError::SourceAddressRequired.into()); |
There was a problem hiding this comment.
Nevermind about my other None comment, the validation is here 🙂
chain/near/src/adapter.rs
Outdated
| .map(|s| s.account.as_ref().cloned().unwrap()) | ||
| .collect(); | ||
|
|
||
| // Parse all the partial accounts, produces all possible combiantions of the values |
mangas
force-pushed
the
near-partial-account-filters
branch
from
a03c891 to
7a3aa52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3628