Removed alphanumeric enforcement for node IDs

graphprotocol · Jun 22, 2022 · 6a2f2e7 · 6a2f2e7
1 parent 28580bb
commit 6a2f2e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/docker/start b/docker/start
@@ -57,7 +57,7 @@ run_graph_node() {
         wait_for_ipfs "$ipfs"
         sleep 5
         graph-node \
-            --node-id "${node_id//-/_}" \
+            --node-id "$node_id" \
             --config "$GRAPH_NODE_CONFIG" \
             --ipfs "$ipfs"
     else
@@ -70,7 +70,7 @@ run_graph_node() {
         sleep 5
 
         graph-node \
-            --node-id "${node_id//-/_}" \
+            --node-id "$node_id" \
             --postgres-url "$postgres_url" \
             --ethereum-rpc $ethereum \
             --ipfs "$ipfs"

diff --git a/graph/src/data/store/mod.rs b/graph/src/data/store/mod.rs
@@ -68,12 +68,6 @@ impl NodeId {
             return Err(());
         }
 
-        // Check that the ID contains only allowed characters.
-        // Note: these restrictions are relied upon to prevent SQL injection
-        if !s.chars().all(|c| c.is_ascii_alphanumeric() || c == '_') {
-            return Err(());
-        }
-
         Ok(NodeId(s))
     }