Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling HTML content #25

Closed
wants to merge 1 commit into from
Closed

Conversation

paulovitorbal
Copy link

Check if it is HTML code as defined by graphviz,
string that starts with < and end with > with some very specific tags inside
It should return the text without any replacement

Check if it is HTML code as defined by graphviz,
string that starts with < and end with > with some very specific tags inside
It should return the text without any replacement
@paulovitorbal
Copy link
Author

This should implement the PR #25

@clue
Copy link
Member

clue commented Oct 9, 2018

@paulovitorbal Thank you very much for picking this up! I've just merged #26 which adds documentation for the existing behavior and also for HTML-like labels. I believe this to resolve this for now :shipit: 🎉

That PR also adds documentation for the existing behavior and the reasoning behind this. All attribute values will be quoted and escaped by default so that a > will be shown as-is without being interpreted as HTML. This is by design to prevent possible injections. As an alternative, the static GraphViz::raw() method can be used as documented to prevent automatic quoting and escaping.

I'd like to get the next release out and believe this has been answered, so I'm closing this for now. :shipit:

Again, thank you! 👍

@clue clue closed this Oct 9, 2018
@paulovitorbal paulovitorbal deleted the patch-1 branch October 11, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants