Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify torch version, which fixed #199 #210

Merged
merged 2 commits into from
May 19, 2022
Merged

Conversation

timephy
Copy link
Contributor

@timephy timephy commented May 17, 2022

Should fix an error which occurs sporadically when training.

@timephy
Copy link
Contributor Author

timephy commented May 17, 2022

Hey @asogaard,
Here is the torch version fix which resolves #199.
I couldn't specify it in envs/gnn_py38.yml as you seem to have moved it to setup.py (78ccf71).
Not sure why torch is not listed in INSTALL_REQUIRES but in the try-expect, but that is where I changed the version. Hope this works!

@asogaard
Copy link
Collaborator

Hi Tim,
Thanks for confirming that this fixes the issue from #199! And to your two comments above:

If we're already bumping versions, perhaps we should try to address #208 right away: Would you mind checking if you can run with the latest stable versions of the torch* packages we use? :)

Copy link
Collaborator

@asogaard asogaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let's just approve and merge this puppy, then we can always address #208 later. 🥳

@asogaard asogaard merged commit a05f45e into graphnet-team:main May 19, 2022
@asogaard
Copy link
Collaborator

asogaard commented Jun 1, 2022

Tag @MortenHolmRep for the above comment re: installing torch/geometric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError: unable to open shared memory object </torch_...> in read-write mode
2 participants