Add link type support to CSV parsing #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snowsign Thanks for submitting a pull request. CSV is not my primary use case, so it has been left a little bit behind. We had planned to improve it as part of the last dev cycle (the v2.x releases) but I felt it needed more thinking and we just ran out of time! I will test your PR and ask @Myllaume to check the code. edit: I don't have a specific timeframe to give you because we haven't yet planned the next development cycle, so I'll get back to you on that. (More info on our "Now" page: https://cosma.arthurperret.fr/now.html) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be completely backwards-compatible with old CSV files. I'm not entirely sure what the "ignored" field in the unit testing CSV file was supposed to be testing, so if that still needs to be there let me know.