Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deduplication bug related to @stream #2304

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Fix deduplication bug related to @stream #2304

merged 5 commits into from
Jan 7, 2025

Conversation

benjie
Copy link
Member

@benjie benjie commented Jan 7, 2025

Description

Streamed vs non-streamed steps shouldn't deduplicate; this caused a bug with pageInfo alongside streamed nodes/edges.

Performance impact

Marginal.

Security impact

Bugfix.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: dd3d22e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
grafast Patch
@localrepo/grafast-bench Patch
@dataplan/json Patch
@dataplan/pg Patch
@grafserv/persisted Patch
grafserv Patch
ruru-components Patch
@localrepo/grafast-website Patch
graphile-build-pg Patch
graphile-build Patch
graphile-utils Patch
pgl Patch
postgraphile Patch
graphile-export Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit 12c908f into main Jan 7, 2025
42 checks passed
@benjie benjie deleted the more-stream-tests branch January 7, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🌳 Triage
Development

Successfully merging this pull request may close these issues.

1 participant