Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: support Prometheus Lexer. #62

Merged
merged 25 commits into from
May 27, 2020
Merged

feature: support Prometheus Lexer. #62

merged 25 commits into from
May 27, 2020

Conversation

Dark0096
Copy link

Background

  • Prometheus is a very powerful monitoring tool. It is used in the Kubernetes environment with multiple ecosystems. Accordingly, the Prometheus query is becoming an essential factor.

Feature

  • Before implementing Prometheus Parser, I developed Lexer that can generate the necessary tokens.
    Next, I will begin to support Prometheus query to implement parser based on prometheusLexer.

Dark0096 added 25 commits March 22, 2020 13:29
@Dark0096
feat: add prometheus lexer for grammar support
965d260
@Dark0096
feat: add duration token analyzer
967cdec
@Dark0096
feat: add NUMBER, SUB, ADD rule
7a53b69
@Dark0096
feat: add comments, identifier rule
afc39ee
@Dark0096
feat: add aggregators, operators rule
70b01ae
@Dark0096
feat: add keywords rule
08935cf
@Dark0096
feat: add edge case fail test
03a1b6a
@Dark0096
feat: add illegal brace check logic in lexer
de36b45
@Dark0096
feat: add illegal syntax check logic in lexer
6341c49
@Dark0096
feat: add illegal syntax check logic in lexer
efe5de5
@Dark0096
feat: add illegal syntax check logic in lexer
fbd252f
@Dark0096
feat: add illegal syntax check logic in lexer
f5ca07f
@Dark0096
feat: add hexadecimal rule in number
466ef3d
@Dark0096
feat: handle unknown token exception
f98cfdc
@Dark0096
feat: handle unknown token exception
d088361
@Dark0096
feat: handle prefix number for duration checking
56107c3
@Dark0096
feat: handle prefix number for duration checking
4eac1d4
@Dark0096
feat: handle prefix number for duration checking
f8eb8b2
@Dark0096
feat: handle prefix number for duration checking
eedf278
@Dark0096
feat: handle prefix number for duration checking
354b778
@Dark0096
feat: verify prometheus sub queries
0075088
@Dark0096
feat: verify prometheus sub queries
3ab6c91
@Dark0096
feat: remove unused grammar
53b42ee
@Dark0096
feat: add duration validation check
6214ad8
@Dark0096
fix: fix ktlint format and add rule for ignore
51ff6f2
@Dark0096 Dark0096 requested a review from jerome89 April 18, 2020 12:02
@Dark0096 Dark0096 added the enhancement New feature or request label Apr 18, 2020
@Dark0096 Dark0096 added this to the 2.0.0 milestone Apr 18, 2020
jerome89
jerome89 approved these changes May 4, 2020
View reviewed changes
Copy link

@jerome89 jerome89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive. Respect your hard work.

@Dark0096 Dark0096 merged commit e9d3d20 into master May 27, 2020
@Dark0096 Dark0096 deleted the feature/prometheus-grammar branch May 27, 2020 12:34
@Dark0096 Dark0096 modified the milestones: 2.0.0, 1.9.0 May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome89 jerome89 jerome89 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Dark0096 @jerome89