forked from Dark0096/graphene
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Graphene can search metrics by tags #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerome89
commented
Jan 2, 2020
- autoComplete API implemented(can be used with Grafana).
- seriesByTag function implemented.
- aliasByTags function implemented.
- groupByTags function implemented with several Grouper functions.
- Path is now treated as Path Object, not String, to be used with tags.
1. autoComplete API implemented(can be used with Grafana). 2. seriesByTag function implemented. 3. aliasByTags function implemented. 4. groupByTags function implemented with several Grouper functions. 5. Path is now treated as Path Object, not String, to be used with tags.
Modified several codes which cannot pass test and lint verification.
Fixed test code
Tests are added in the following functions: 1. groupByTags 2. aliasByTags Changed author's name.
Dark0096
reviewed
Jan 5, 2020
graphene-function/src/main/java/com/graphene/reader/graphite/functions/GrapheneFunction.java
Show resolved
Hide resolved
…m tag-based indexes.
…itoring/graphene into feature/tag-support
Multiple conditions in when clause will not be invoked other than the first condition. This is a property of when clause of Kotlin, but I missed so I've patched this in optimizer.
Dark0096
approved these changes
Jan 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
…support feat: refactor partial code snippet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.