Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Graphene can search metrics by tags #38

Merged
merged 15 commits into from
Jan 12, 2020
Merged

Conversation

jerome89
Copy link

@jerome89 jerome89 commented Jan 2, 2020

  1. autoComplete API implemented(can be used with Grafana).
  2. seriesByTag function implemented.
  3. aliasByTags function implemented.
  4. groupByTags function implemented with several Grouper functions.
  5. Path is now treated as Path Object, not String, to be used with tags.

1. autoComplete API implemented(can be used with Grafana).
2. seriesByTag function implemented.
3. aliasByTags function implemented.
4. groupByTags function implemented with several Grouper functions.
5. Path is now treated as Path Object, not String, to be used with tags.
Modified several codes which cannot pass test and lint verification.
@jerome89 jerome89 added the enhancement New feature or request label Jan 2, 2020
@jerome89 jerome89 added this to the 1.6.0 milestone Jan 2, 2020
@jerome89 jerome89 requested a review from Dark0096 January 2, 2020 04:00
@jerome89 jerome89 self-assigned this Jan 2, 2020
@Dark0096 Dark0096 modified the milestones: 1.6.0, 1.7.0 Jan 2, 2020
Tests are added in the following functions:
1. groupByTags
2. aliasByTags
Changed author's name.
@Dark0096 Dark0096 changed the base branch from master to 2.0.0 January 5, 2020 04:29
@Dark0096 Dark0096 modified the milestones: 1.7.0, 2.0.0 Jan 5, 2020
@Dark0096 Dark0096 changed the base branch from 2.0.0 to master January 11, 2020 12:07
@Dark0096 Dark0096 modified the milestones: 2.0.0, 1.7.0 Jan 11, 2020
jerome89 and others added 2 commits January 12, 2020 16:32
Multiple conditions in when clause will not be invoked other than the first condition.
This is a property of when clause of Kotlin, but I missed so I've patched this in optimizer.
Copy link

@Dark0096 Dark0096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Dark0096 Dark0096 merged commit 9556184 into master Jan 12, 2020
@Dark0096 Dark0096 deleted the feature/tag-support branch January 12, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants