Allow schema to be omitted when using default root op names
#364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dackroyd
commented
Oct 30, 2019
graphql_test.go
Outdated
| @@ -2512,15 +2742,19 @@ func (r *inputResolver) Nullable(args struct{ Value *int32 }) *int32 { | |||
| return args.Value | |||
| } | |||
|
|
|||
| func (r *inputResolver) List(args struct{ Value []*struct{ V int32 } }) []int32 { | |||
| func (r *inputResolver) List(args struct { | |||
There was a problem hiding this comment.
Crept in, will revert these unrelated changes
dackroyd
commented
Oct 30, 2019
| @@ -362,7 +362,8 @@ func (b *execBuilder) makeFieldExec(typeName string, f *schema.Field, m reflect. | |||
| var out reflect.Type | |||
| if methodIndex != -1 { | |||
| out = m.Type.Out(0) | |||
| if typeName == "Subscription" && out.Kind() == reflect.Chan { | |||
| sub, ok := b.schema.EntryPoints["subscription"] | |||
There was a problem hiding this comment.
This is an existing bug which prevents the subscription root op having a type named anything other than Subscription. Had to fix it here to verify correct behaviour for custom type names, but can split that work if desired
dackroyd
force-pushed
the
populate-default-entrypoints-without-explicit-schema
branch
from
10ae3b8
to
6c0f0e3
Compare
|
Looking through open PRs on the repo, I notice that this has been raised previously under #126 back in 2017, but never merged. The codebase has drifted quite a lot since then, so it has picked up a few conflicts |
dackroyd
commented
Oct 30, 2019
| } | ||
| return nil | ||
| } | ||
| if t.Kind() != "OBJECT" { |
There was a problem hiding this comment.
if _, ok := t.(*schema.Object); !ok {
^ could be a better way of checking this?
This was referenced Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304