feat(pick): use RandomGenerator as the base class

grandom-library · Aug 19, 2023 · d4e635c · d4e635c
1 parent 67b0099
commit d4e635c
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 36 deletions.
diff --git a/packages/pick/package-lock.json b/packages/pick/package-lock.json
diff --git a/packages/pick/package.json b/packages/pick/package.json
@@ -50,19 +50,19 @@
     "@types/semantic-release": "^20.0.1",
     "jest": "^29.6.2",
     "jest-extended": "^4.0.1",
-    "rollup": "^3.26.3",
+    "rollup": "^3.28.0",
     "semantic-release": "^19.0.5",
     "semantic-release-monorepo": "^7.0.5",
     "snazzy": "^9.0.0",
     "string-dedent": "^3.0.1",
     "ts-jest": "^29.1.1",
     "ts-node": "^10.9.1",
     "ts-standard": "^12.0.2",
-    "tslib": "^2.6.0",
+    "tslib": "^2.6.2",
     "typescript": "^4.9.4"
   },
   "dependencies": {
-    "@grandom/core": "^1.6.0",
-    "@grandom/engines": "^1.0.2"
+    "@grandom/core": "^2.4.0",
+    "@grandom/engines": "^2.1.0"
   }
 }
diff --git a/packages/pick/src/RandomPick/index.ts b/packages/pick/src/RandomPick/index.ts
@@ -1,8 +1,7 @@
-
 // TODO: include / exclude / filter function
 // TODO: implement edge cases (including infinite loops)
 
-import { RandomEngine } from '@grandom/core'
+import { RandomGenerator } from '@grandom/core'
 
 const DEFAULT_FALLBACK = undefined
 
@@ -82,20 +81,20 @@ const unique = grandom.pick.multiple.unique([1, 2, 3], { count: 2, default: -1 }
 //   }
 // }
 
-export default class RandomPick {
-  private readonly _engine: RandomEngine
+export default class RandomPick extends RandomGenerator {
+  // private readonly _engine: RandomEngine
 
-  constructor (engine: RandomEngine) {
-    this._engine = engine
+  // constructor (engine: RandomEngine) {
+  //   this._engine = engine
 
-    // const pick: Pick = (arg1: any, arg2?: any): any => {}
-    // pick.multiple = (arg1: any, arg2: any): any => {}
-    // // pick.multiple.unique = (arg1: any, arg2?: any): any => { return () => null }
-    // pick.unique = (arg1: any, arg2?: any) => { return (): any => null }
-    // pick.unique.multiple = (arg1: any, arg2: any) => { return (): any => null }
+  //   // const pick: Pick = (arg1: any, arg2?: any): any => {}
+  //   // pick.multiple = (arg1: any, arg2: any): any => {}
+  //   // // pick.multiple.unique = (arg1: any, arg2?: any): any => { return () => null }
+  //   // pick.unique = (arg1: any, arg2?: any) => { return (): any => null }
+  //   // pick.unique.multiple = (arg1: any, arg2: any) => { return (): any => null }
 
-    // this.pick = pick
-  }
+  //   // this.pick = pick
+  // }
 
   // pick: Pick
 

diff --git a/packages/pick/src/index.ts b/packages/pick/src/index.ts
@@ -1,4 +1,4 @@
-import { BasicEngine } from '@grandom/engines'
+import BasicEngine from '@grandom/engines/basic'
 import RandomPick from './RandomPick'
 
 const random = new RandomPick(new BasicEngine())