Refactor to async methods and remove RabbitMQ #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored various services and controllers to use asynchronous methods for improved performance and responsiveness. Removed `MassTransit` and `MassTransit.RabbitMQ` packages and related RabbitMQ configuration and code. Updated `appsettings.json` to remove RabbitMQ settings and enable `Grand.Module.Api` feature. Modified tests to align with asynchronous changes.
Modified GeneratedThumbExists in AmazonPictureService to be async. Changed method signature to async Task<bool>. Replaced synchronous GetObjectAsync call with await. Simplified return statements for better readability. Updated catch block to return false directly. Improves performance and adheres to modern async practices.
- Removed `clearCache` parameter from `InsertSetting`, `UpdateSetting`, and `SetSetting` methods in `SettingService` class; cache is now always cleared. - Updated `ISettingService` interface to reflect the removal of `clearCache` parameter. - Fixed syntax error in `AmazonPictureService` by removing an extra closing parenthesis. - Removed `_disposed` field from `MemoryCacheBase`. - Improved readability in `ShippingFixedRateController` by removing an unnecessary line break in `SetSetting` method call. - Updated `PaymentServiceTests` to match the new `SetSetting` method signature without the `clearCache` parameter.
Refactored `LoadSetting` methods in `SettingService` and `ISettingService` to be synchronous. Updated `ICacheBase` and `MemoryCacheBase` to include and implement synchronous `Get` methods. Removed unused `using` directive from `ServiceCollectionExtensions.cs` and updated it to use the synchronous `LoadSetting` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored various services and controllers to use asynchronous methods for improved performance and responsiveness. Removed
MassTransitandMassTransit.RabbitMQpackages and related RabbitMQ configuration and code. Updatedappsettings.jsonto remove RabbitMQ settings and enableGrand.Module.Apifeature. Modified tests to align with asynchronous changes.