-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update initial earliest_exit_epoch calculation #68
Update initial earliest_exit_epoch calculation #68
Conversation
Hi @Tumas, this spec is already implemented in devnet-5 branch, just want to know what do you think about this alter aproach as context in devnet-5 branch: grandine/helper_functions/src/fork.rs Lines 549 to 561 in bfdaff2
|
Looks good, can you change the target to devnet5? |
I guess I have to change the base branch since a few commits from |
I've rebased devnet5 on develop, so now only the code conflicts are left. |
3b93447
to
1b6bb47
Compare
all good now |
It now shows 10 commits with this merge request, can you squash all your changes into 1 commit? |
format code resolved conflict
116e8b9
to
bde9e99
Compare
sorry for took much time on fixing my messy commits history, done squashing those commits into one |
Thanks @hangleang , if you would like to work on Pectra then the best way would be to do Kurtosis interop with other clients (the config is in Ethereum R&D discord #interop chat) and debug the issues. |
Yes, but I will prioritize PeerDAS work since the implementation is not stable yet. If I still have some time left, I will pick up some easy tasks or quick-fix issues to work on. |
@hangleang sure, but PeerDAS is a bit stalled since everyone is focusing on Pectra. |
yeah, once I'm done with the rebase and switch to custody groups, and feel confident enough if the next devnet launch is announced, grandine is ready to go |
reference spec change: ethereum/consensus-specs#4001