Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update initial earliest_exit_epoch calculation #68

Merged

Conversation

hangleang
Copy link
Contributor

@hangleang hangleang commented Dec 21, 2024

reference spec change: ethereum/consensus-specs#4001

@hangleang
Copy link
Contributor Author

hangleang commented Dec 21, 2024

Hi @Tumas, this spec is already implemented in devnet-5 branch, just want to know what do you think about this alter aproach

as context in devnet-5 branch:

let mut earliest_exit_epoch = misc::compute_activation_exit_epoch::<P>(epoch);
for exit_epoch in validators
.into_iter()
.map(|validator| validator.exit_epoch)
.filter(|exit_epoch| *exit_epoch != FAR_FUTURE_EPOCH)
{
if exit_epoch > earliest_exit_epoch {
earliest_exit_epoch = exit_epoch;
}
}
earliest_exit_epoch += 1;

@Tumas
Copy link
Member

Tumas commented Dec 21, 2024

Looks good, can you change the target to devnet5?

@hangleang hangleang changed the base branch from develop to devnet5 December 21, 2024 18:22
@hangleang
Copy link
Contributor Author

I guess I have to change the base branch since a few commits from develop come along as well

@Tumas
Copy link
Member

Tumas commented Dec 21, 2024

I've rebased devnet5 on develop, so now only the code conflicts are left.

@hangleang hangleang force-pushed the fix/initial-earliest-exit-epoch branch from 3b93447 to 1b6bb47 Compare December 21, 2024 18:32
@hangleang
Copy link
Contributor Author

all good now

@Tumas
Copy link
Member

Tumas commented Dec 21, 2024

It now shows 10 commits with this merge request, can you squash all your changes into 1 commit?

format code

resolved conflict
@hangleang hangleang force-pushed the fix/initial-earliest-exit-epoch branch from 116e8b9 to bde9e99 Compare December 21, 2024 19:17
@hangleang
Copy link
Contributor Author

sorry for took much time on fixing my messy commits history, done squashing those commits into one

@Tumas Tumas merged commit e678bce into grandinetech:devnet5 Dec 21, 2024
1 check passed
@sauliusgrigaitis
Copy link
Member

Thanks @hangleang , if you would like to work on Pectra then the best way would be to do Kurtosis interop with other clients (the config is in Ethereum R&D discord #interop chat) and debug the issues.

@hangleang
Copy link
Contributor Author

Yes, but I will prioritize PeerDAS work since the implementation is not stable yet. If I still have some time left, I will pick up some easy tasks or quick-fix issues to work on.

@sauliusgrigaitis
Copy link
Member

@hangleang sure, but PeerDAS is a bit stalled since everyone is focusing on Pectra.

@hangleang
Copy link
Contributor Author

yeah, once I'm done with the rebase and switch to custody groups, and feel confident enough if the next devnet launch is announced, grandine is ready to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants