Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Portuguese] Translate locales #886

Merged
merged 3 commits into from
Aug 9, 2023
Merged

[Portuguese] Translate locales #886

merged 3 commits into from
Aug 9, 2023

Conversation

roziscoding
Copy link
Contributor

No description provided.

@roziscoding roziscoding added the not translatable Translator intervention is not required. label Aug 9, 2023
@roziscoding roziscoding requested a review from kr4t0z August 9, 2023 01:25
@github-actions
Copy link

github-actions bot commented Aug 9, 2023 •
edited
Loading

🚀 Deployed on https://64d361f5cdf03e4960997410--grammy.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 01:28 Inactive
@roziscoding roziscoding changed the base branch from main to pt August 9, 2023 01:39
@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 01:42 Inactive
kr4t0z
kr4t0z suggested changes Aug 9, 2023
View reviewed changes
Copy link

@kr4t0z kr4t0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides adjustments, LGTM

site/docs/.vitepress/configs/locales/pt.ts Outdated Show resolved Hide resolved
site/docs/.vitepress/configs/locales/pt.ts Outdated Show resolved Hide resolved
site/docs/.vitepress/configs/locales/pt.ts Outdated Show resolved Hide resolved
@roziscoding roziscoding linked an issue Aug 9, 2023 that may be closed by this pull request
Portuguese (Brazil) translation tracking #884
Closed
64 tasks
@roziscoding @kr4t0z
fix: apply suggestions from code review
3899ba2 
Co-authored-by: Kratos <xkrat0zx@protonmail.com>
@roziscoding roziscoding requested a review from kr4t0z August 9, 2023 02:29
@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 02:30 Inactive
rojvv
rojvv reviewed Aug 9, 2023
View reviewed changes
Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing the language code to pt-br or something like that?

@roziscoding
Copy link
Contributor Author

How about changing the language code to pt-br or something like that?

We've discussed this, but since we're unlikely do have a pt-pt translation (just because the pt-br one should work well for pt-pt speakers) and the other files and folders don't specify a country, we decided to keep it consistent

@rojvv
Copy link
Member

rojvv commented Aug 9, 2023

You mean Portuguese speakers in Portugal will understand your translations?

@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 09:53 Inactive
@roziscoding
Copy link
Contributor Author

roziscoding commented Aug 9, 2023 •
edited
Loading

You mean Portuguese speakers in Portugal will understand your translations?

Yes. The two variants are pretty much interchangeable. It comes down to personal preference or, in this case, availability of translators

@kr4t0z kr4t0z merged commit 91452d5 into pt Aug 9, 2023
4 checks passed
@kr4t0z kr4t0z deleted the pt-.vitepress-configs-locales-pt branch August 9, 2023 12:46
@roziscoding roziscoding mentioned this pull request Aug 10, 2023
Closed
roziscoding added a commit that referenced this pull request Aug 11, 2023
@roziscoding @kr4t0z @rojvv
[Portuguese] Translate locales (#886)
7e14390 
Co-authored-by: Kratos <xkrat0zx@protonmail.com>
Co-authored-by: Roj <rojvv@icloud.com>
@roziscoding roziscoding removed a link to an issue Oct 18, 2023
Portuguese (Brazil) translation tracking #884
Closed
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rojvv rojvv rojvv left review comments

@kr4t0z kr4t0z Awaiting requested review from kr4t0z

Assignees
No one assigned
Labels
not translatable Translator intervention is not required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roziscoding @rojvv @kr4t0z