Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Algolia search #861

Merged
merged 8 commits into from
Jul 16, 2023
Merged

Use Algolia search #861

merged 8 commits into from
Jul 16, 2023

Conversation

quadratz
Copy link
Contributor

@quadratz quadratz commented Jul 5, 2023

@quadratz quadratz added not translatable Translator intervention is not required. chore Modifies or is related to tooling, configuration, or setup. labels Jul 5, 2023
@quadratz quadratz changed the title Use Algolia seach Use Algolia search Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

@github-actions github-actions bot temporarily deployed to pull request July 5, 2023 00:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2023 00:07 Inactive
@quadratz
Copy link
Contributor Author

quadratz commented Jul 5, 2023

Mmm.. Why is this not returning any result?

@quadratz
Copy link
Contributor Author

quadratz commented Jul 5, 2023

Maybe due to this #855?

@KnorpelSenf
Copy link
Member

No, the index just isn't updated anymore. It's still there. For example, the bot still works.

Algolia was not returning any search due to the mismatched language code
@github-actions github-actions bot temporarily deployed to pull request July 5, 2023 08:19 Inactive
@quadratz quadratz marked this pull request as ready for review July 5, 2023 08:26
@KnorpelSenf
Copy link
Member

Did the search just got a lot faster? This seems to work much better than the internal search (on my device)

@quadratz
Copy link
Contributor Author

quadratz commented Jul 5, 2023

That's possible. Maybe the build version is more optimized for Algolia.

@github-actions github-actions bot temporarily deployed to pull request July 5, 2023 15:31 Inactive
@quadratz
Copy link
Contributor Author

quadratz commented Jul 5, 2023

If only we could solve the result limit problem (currently max 5 results) and have ability to split the results based on each section like vuepress does, I would prefer choose Algolia as the main search engine.

@KnorpelSenf
Copy link
Member

If only we could solve the result limit problem (currently max 5 results) and have ability to split the results based on each section like vuepress does, I would prefer choose Algolia as the main search engine.

I think it should be possible to add this to vitepress sooner or later.

@quadratz quadratz marked this pull request as draft July 9, 2023 13:57
@KnorpelSenf
Copy link
Member

What is missing here?

@github-actions github-actions bot temporarily deployed to pull request July 12, 2023 08:53 Inactive
Fix empty search result for Chinese pages
@github-actions github-actions bot temporarily deployed to pull request July 12, 2023 08:57 Inactive
@quadratz quadratz marked this pull request as ready for review July 12, 2023 08:59
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a text file to this repo which contains the Algolia config that we use. Similarly to the IV rules, it will not be synced with Algolia automatically. However, the config is necessary in order to build the site locally and it's somehow part of our logic.

Otherwise, LGTM.

@quadratz
Copy link
Contributor Author

Just to be clear, I should create two files: one with our Algolia crawler config similar to this one, and another with the IV rules from the following repository, correct?

@KnorpelSenf
Copy link
Member

No, just one file with the config. The IV rules are in the docs bot repo. You can update them there. I was just giving an example :)

@github-actions github-actions bot temporarily deployed to pull request July 15, 2023 14:14 Inactive
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@KnorpelSenf
Copy link
Member

@roj1512 your turn

Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know if I know anything about this, but I know that I trust you.

@rojvv rojvv added this pull request to the merge queue Jul 16, 2023
Merged via the queue into main with commit e7a3cb5 Jul 16, 2023
4 checks passed
@rojvv rojvv deleted the algolia-my-old-friend branch July 16, 2023 07:51
@KnorpelSenf
Copy link
Member

whoop whoop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Modifies or is related to tooling, configuration, or setup. not translatable Translator intervention is not required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants