Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bun related docs (@stonega) #1129

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: bun related docs (@stonega) #1129

wants to merge 7 commits into from

Conversation

MasedMSD
Copy link
Collaborator

@MasedMSD MasedMSD commented Oct 1, 2024

Originally PR was created by @stonega, but it looks like he's not going to continue with this PR. So, I think we should mention Bun as a possible way to work with a bot, even though Bun has a large number of issues. Also Bun finally supports conversations plugin and a decent part of Russian language chat users use it for their projects.

I made some changes and added Bun mentions to the hosting files documentation

- changed bot.ts to index.ts
- mention bun at hosting docs
Copy link

github-actions bot commented Oct 1, 2024

@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 13:47 Inactive
site/docs/guide/getting-started.md Show resolved Hide resolved
site/docs/guide/introduction.md Outdated Show resolved Hide resolved
@MasedMSD
Copy link
Collaborator Author

MasedMSD commented Oct 2, 2024

Should we leave index.ts or should we tell the user to create a bot.ts file each time in order for the NodeJS and Deno examples to be the same?

@KnorpelSenf
Copy link
Member

I have now wasted more time on this than I ever wanted, maybe I'll get back to this in a week or so

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bottom line of this is still that whatever we do with the tutorial, the output must look exactly like

Create a new empty text file, e.g. called `bot.ts`.
Your folder structure should now look like this:
```asciiart:no-line-numbers
.
├── bot.ts
├── node_modules/
├── package.json
├── package-lock.json
└── tsconfig.json
```
and the file contents need to be the same, too. I still do not really care how that is achieved, the point is that as long as the bun guide does not lead to the correct setup, then this cannot be merged.

@github-actions github-actions bot temporarily deployed to pull request October 15, 2024 15:41 Inactive
@MasedMSD
Copy link
Collaborator Author

I'll get into this page in more detail tomorrow

@KnorpelSenf
Copy link
Member

Remember to merge main in order to fix CI

@KnorpelSenf
Copy link
Member

Scratch that, it already happened

@KnorpelSenf
Copy link
Member

I even did it myself *facepalm*

@github-actions github-actions bot temporarily deployed to pull request October 15, 2024 19:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 16, 2024 09:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 16, 2024 09:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 16, 2024 11:11 Inactive
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still does not create the same TS config as tsc --init if I understand this correctly

@MasedMSD
Copy link
Collaborator Author

Unfortunately we can't fix it. We will have to ask the user to change it manually every time.
But I don't understand the point of this, because everything works with the current tsconfig O.O

@KnorpelSenf
Copy link
Member

Yeah but I don't want to go through all the code examples and make sure that they compile even with the non-standard TS config that bun introduces. It can be fixed very easily by running tsc --init in the getting started guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants