Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: else clause on new line #678

Merged
merged 1 commit into from
Jun 5, 2021
Merged

fix: else clause on new line #678

merged 1 commit into from
Jun 5, 2021

Conversation

ospencer
Copy link
Member

Fixes #650

@ospencer ospencer requested a review from a team May 30, 2021 11:36
@ospencer ospencer self-assigned this May 30, 2021
phated
phated approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like elses on new lines.

@ospencer
Copy link
Member Author

ospencer commented Jun 5, 2021

The code never bothered me anyway.

@ospencer ospencer merged commit 13b01c9 into main Jun 5, 2021
@ospencer ospencer deleted the newline-else branch June 5, 2021 23:55
@github-actions github-actions bot mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@marcusroberts marcusroberts marcusroberts approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Putting else statement on a new line causes a syntax error
3 participants
@ospencer @phated @marcusroberts