Split GCP deployment into separate manually run GitHub Workflows for release and snapshot #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eploy in snapshot.yml adjust Java versions, the snapshot workflow is now run manually so the desired branch or tag can be deployed
jamesfredley
changed the title
jamesfredley
changed the title
matrei
approved these changes
Dec 10, 2024
jdaugherty
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split GCP deployment into separate manually run GitHub Workflow for release and snapshot in order to control what gets deployed. Currently an old version release (IE. 6.1.3) will clogger the current version release (IE. 6.2.2), same for snapshot.
gradle.yml- Java CI build for snapshots, does not deploy to GCPsnapshotandanalytics-snapshotenvironmentsrelease.yml- Release build and publish, does not deploy to GCPlatestandanalytics-latestenvironmentssnapshot-gcp-deploy.yml- manually run to deploy to GCPsnapshotandanalytics-snapshotenvironmentsrelease-gcp-deploy.yml- manually run to deploy to GCPlatestandanalytics-latestenvironmentsnew workflows will not appear and allow manual run on https://github.com/grails/grails-forge/actions until they are merged into the default branch (7.0.x)
deploy.ymlwill also be removed in 6.2.x and 7.0.x, since it is replaced byrelease-gcp-deploy.yml.deploy.ymldoes not include redeploy of analytics.https://github.com/grails/grails-forge/blob/6.1.x/.github/workflows/deploy.yml
This will get merged up to 6.1.x, 6.2.x and 7.0.x after review.
There may be a little extra left in
release-gcp-deploy.yml, I errored on the side of doing extra steps vs missing something.