dependency cleanup with grails-bom #411
Conversation
...e-core/src/main/java/org/grails/forge/feature/build/gradle/templates/dependencies.rocker.raw
Outdated
Show resolved
Hide resolved
...src/main/java/org/grails/forge/feature/build/gradle/templates/buildSrcBuildGradle.rocker.raw
Show resolved
Hide resolved
|
This PR addresses the current breakage on Grails apps generated on https://start.grails.org/ |
grails-forge-core/src/main/java/org/grails/forge/feature/test/Geb.java
Outdated
Show resolved
Hide resolved
| @@ -105,24 +105,29 @@ public void apply(GeneratorContext generatorContext) { | |||
| .artifactId("geb") | |||
| .test()); | |||
There was a problem hiding this comment.
This should be included as integrationTestImplementation testFixtures('org.grails.plugins:geb')
However, to be able to run the create-functional-test command (which has not been upgraded to a Grails 6 GrailsApplicationCommand), I'm not yet sure what needs to be put where. Is there any point in rewriting the create-functional-test command as a GrailsApplicationCommand now that the grails-shell cli is back?
There was a problem hiding this comment.
I'll test this with a generated app and then make the changes in forge. It was not loading the transitive geb-spock dependency as is, but it wasn't using integrationTestImplementation testFixtures
There was a problem hiding this comment.
"integrationTestImplementation testFixtures('org.grails.plugins:geb' worked great and that scope is now an option in forge.
I think we should hold off on command conversions.
grails-forge-core/src/main/java/org/grails/forge/feature/test/Geb.java
Outdated
Show resolved
Hide resolved
This PR uses Gradle Release Flag instead of Java Toolchain to provide more control over the version of Java. sourceCompatibility is deprecated and marked for removal in Gradle 9. https://docs.gradle.org/current/userguide/building_java_projects.html#sec:compiling_with_release
bumps Gradle down to 8.6 in the project and the generated Grails app until there is a resolution for grails/grails-testing-support#443
implementation platformhas to be applied to buildSrc also until #406