fix(deps): Update to Grails 7, Gradle 8.10.2 and grails-core dependency versions #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nger set by grails-bom
Merged
# Conflicts: # gradle.properties # grails-forge-core/src/main/resources/pom.xml # grails-forge-core/src/test/groovy/org/grails/forge/build/gradle/GradleSpec.groovy # grails-forge-core/src/test/groovy/org/grails/forge/feature/grails/GrailsGradlePluginSpec.groovy
Mostly removing micronaut dependencies from generated `build.gradle` I just used comments here pending we figure out the correct course of action.
…y handling - Explicitly set the version for `micronaut-http-client`, previously managed by `grails-bom` in Grails 6. - Remove default inclusion of `micronaut-http-client` as a test dependency when the `micronaut-http-client` feature is not selected.
jamesfredley
changed the title
matrei
approved these changes
Oct 10, 2024
| // micronaut-http-client no longer provides the jackson implementation | ||
| generatorContext.addDependency(Dependency.builder() | ||
| .groupId("io.micronaut.serde") | ||
| .lookupArtifactId("micronaut-serde-jackson") | ||
| .compile()); |
There was a problem hiding this comment.
I am going to leave it for now, since I am not 100% sure runtime will cover all standard use cases and since this is an optional feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not include Micronaut or Groovy upgrades.