refactor: Move forcing of groovy-xml to buildSrc #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Gradle 7.6 together with the Grails Gradle Plugin and groovy files in src/*/groovy there is a clash between the version bundled with Gradle (3.0.13) and the version loaded by the Grails Gradle Plugin (3.0.11). This forces the version to be compatible with Gradle for compiling groovy files in buildSrc. This was previously included in the application's build.gradle leading to unnecessary clutter.
Instead of hard-coding the Groovy version bundled with Gradle it is better to get it at runtime.
puneetbehl
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Gradle 7.6 together with the Grails Gradle Plugin and groovy files in src/*/groovy there is a clash between the version bundled with Gradle (3.0.13) and the version loaded by the Grails Gradle Plugin (3.0.11). This forces the version to be compatible with Gradle for compiling groovy files in buildSrc.
This was previously included in the application's build.gradle leading to unnecessary clutter.