Include Icon Path in Summary Result #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahampugh
added
enhancement
|
Hey Graham, I have updated this PR to match the current code base and after looking at the code a second time....I see it could be greatly simplified, so I have done that. If you would be willing to merge this, I could stop running a customized version finally. 😁 |
|
Hi, you'll need to look at the Refactor branch I'm afraid. I moved all the functions of each processor into "Base" processors to avoid so many trust-updates in the future. |
|
Ah, I merged the latest changes in main into this old branch. I don't see a "refactor" branch....unless I'm missing something..? |
|
Oh yes, I forgot that I merged the branch to main already! Cool, then it's easy. I should be able to take a look tomorrow. |
|
Thank you sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a wrapper around my
autopkg run's and I have a use for the icon's path in that post logic. The value is already known during the Processor run, this change will simply include thepolicy_icon_pathvalue in thejamfpolicyuploader_summary_resultskey so that it can be extracted easily.