Supported Material Design 3 for the BottomAppBar (Android) #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings in material 3 for BottomAppBar
On new architecture a fab anchored to bottom app bar and aligned to the end overlapped the buttons (didn't overlap on material 3 but think that's because end is the default alignment). I'm guessing this is because the order of events have changed but not sure. Requesting another layout when attached to window fixed it
When double tap tab then scroll to top. So need to show the bottom app bar that might be hidden when hideOnScroll
Same change as before but for non-primary tabs
grahammendick
changed the title
|
React Native has bumped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Android material components to v1.7.0 to support Material Design 3 for the BottomAppBar. Set height to 80dp to match the Material 3 specs if the user opts in by using a
Material3Theme.Material components v1.7.0 updated the
compileSdkVersionandtargetSdkVersionto 32. Currently, React Native 0.70 has these at 31 so not going to merge this PR yet. It looks like React Native 0.71 bumps these to 33 which would avoid having to add a manual bump step to the setup instructions.