Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: response middleware extra info #788

Merged

Conversation

sayjeyhi
Copy link
Contributor

@sayjeyhi sayjeyhi commented Apr 19, 2024

This gives possibility to check request parameters in response middleware and can be used in different scenarios

@sayjeyhi
Copy link
Contributor Author

closes: #787

Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayjeyhi LGTM! Can you just add some test coverage, thanks!

@jasonkuhrt jasonkuhrt changed the title Feat/response middleware extra info feat: response middleware extra info Apr 20, 2024
@sayjeyhi
Copy link
Contributor Author

@sayjeyhi LGTM! Can you just add some test coverage, thanks!

@jasonkuhrt done. thanks.

Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@jasonkuhrt jasonkuhrt merged commit cc2dc55 into graffle-js:main Apr 21, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants